Issue 3654 addr based loop detection#5767
Merged
SolidWallOfCode merged 2 commits intoapache:masterfrom Aug 8, 2019
Merged
Conversation
…as the inbound already connected to. Closes apache#3654
Contributor
|
[approve ci autest] |
shinrich
approved these changes
Aug 8, 2019
Contributor
|
@SolidWallOfCode there is a Machine::is_self(const char *name) and a Machine::is_self(const IPaddr *ipaddr). at ATS startup, the IP's of all the configured network interfaces are in a map, is_self(ipaddr) will tell you if the ipaddr is it self. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two distinct problems.
IP address based loop detection for single address systems. As far as I can tell, loop detection doesn't work on hosts with a single address, due to port byte ordering problems.
Issue ATS request cycle in multiple network interface #3654 - the address based check only checks a single address. If the request is for a different address on the same machine, to which a proxy port is bound (common case) then the loop is not detected. This fix checks if the destination address / port is the same as the inbound local address / port, which means the connection is looping.