Merged
Conversation
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Apr 12, 2016
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
Contributor
Author
|
This isn't complete yet, still need to add handling for timeouts etc., but I wanted to get the PR opened to get some eyes on it :) |
Member
|
👀 I'm on it. |
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Apr 12, 2016
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
Contributor
Author
|
Well, it seems that this doesn't leak in the queue-- but I did find another bug (https://issues.apache.org/jira/browse/TS-4343) which we'll probably want to fix at the same time as this :/ |
c68064c to
4b9c30f
Compare
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Apr 14, 2016
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Apr 14, 2016
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
Contributor
Author
Contributor
Author
| } else if (ats_is_ip6(addr)) { | ||
| ink_code_md5(const_cast<uint8_t *>(ats_ip_addr8_cast(addr)), TS_IP6_SIZE, zret.c); | ||
| // now replace the bottom 16bits so we can account for the port. | ||
| zret.b[3] = ats_ip_port_cast(addr); |
Contributor
Author
There was a problem hiding this comment.
It seems that this returns nothing/garbage in the ipv6 case-- as both lines in ipv6 simply add to .b and .c, but the method only returns .i.
Contributor
Author
There was a problem hiding this comment.
That being said, it seems to do the same thing in ats_ip_hash, which also seems like it wouldn't work :/
Contributor
There was a problem hiding this comment.
zret is a union; it's the same data.
Contributor
Author
There was a problem hiding this comment.
@jpeach thanks for calling out my stupid, for whatever reason I read it as struct ;) So nevermind then-- we are all set :)
Member
|
@jacksontj I'm going to merge my pull request, can you please update yours once my code lands? Thanks |
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Apr 14, 2016
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
if you have `origin_max_connections` set, it will limit the number of sessions sent to a given origin. Once the limit is hit ATS would infinitely queue requests waiting for the origin to respond. In the event that the origin is broken (and will stay so) it is better to error the pages, on the flip side if you want ATS to just limit the number of connections you don't want to just close the connections. To handle both of these I've introduced `origin_max_connections_queue`. This option limits the number of outstanding connections allowed to a given origin. A value <0 defaults to the old behavior (no limits). If set to 0 all requests past the limit are errored, and if the limit is >0 then that many requests are allowed to be outstanding to the origin. This closes apache#564
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
Cherrypick: Add SINK_TRANSFORM option to CPPAPI
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS-4341