TS-4320: Add ACME Plugin #560
Conversation
|
Looks ok, +1. |
|
|
||
| static const char PLUGIN_NAME[] = "acme"; | ||
| static const char ACME_WK_PATH[] = ".well-known/acme-challenge/"; | ||
| static const char ACME_OK_RESP[] = "HTTP/1.1 200 OK\r\nContent-Type: application/jose\r\nCache-Control: no-cache\r\n"; |
There was a problem hiding this comment.
no-cache (https://tools.ietf.org/html/rfc7234#section-5.2.1.4) or no-store (https://tools.ietf.org/html/rfc7234#section-5.2.1.5)? Eg, cache it, but validate before serving from cache, or don't cache it at all?
There was a problem hiding this comment.
Yeah, lets make it CC: no-store,private. This likely is in several other plugins that this is stole^h^h^h borrowed from. Perhaps file a Jira on fixing those as well?
There was a problem hiding this comment.
I agree, we should make a separate JIRA and get all these at once. I'll leave this be for now.
|
Could you include a readme or better a doc page (https://docs.trafficserver.apache.org/en/latest/developer-guide/documentation/plugins.en.html) explaining what this is and does? |
plugins/experimental/acme/acme.c
Outdated
| typedef struct AcmeConfig_t { | ||
| char *proof; | ||
| } AcmeConfig; | ||
| AcmeConfig gConfig; |
Address the AM_CFLAGS AM_CXXFLAGS in tsxs.in
…ail and print to stderr in case of an error. (apache#560)
…ail and print to stderr in case of an error. (apache#560)
…ail and print to stderr in case of an error. (apache#560)
…ail and print to stderr in case of an error. (apache#560)
…ail and print to stderr in case of an error. (apache#560)
…ail and print to stderr in case of an error. (apache#560)
This is a first pass at making an ACME plugin for ATS. This current version amounts to a simple static file server that leverages a CLI client, but there are plans to make this a fully standalone implementation down the road.