Reverting fadddccd53c4e8f41553fef6ca0630f0124ed4a0 and fixing up b6f4227fe3f4b9ce344f159ac505258228fa8aeb#4503
Merged
zwoop merged 1 commit intoapache:7.1.xfrom Oct 27, 2018
Merged
Conversation
…evert cleanly
This was referenced Oct 26, 2018
Contributor
|
[approve ci] |
zwoop
approved these changes
Oct 27, 2018
Contributor
|
Removing the Milestone from this, since this is a no-op now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the latest 7.1.x we saw a crash that kept coming up, https://gist.github.com/ezelkow1/6514f3ddb7a68e2b3279ae3a26cb0021
This seemed to be triggered by an unknown event in the state machine:
[Oct 26 18:25:07.032] Server {0x2b9b78a09700} ERROR: <HttpSM.cc:1803 (state_http_server_open)> [HttpSM::state_http_server_open] Unknown event: 105 (VC_EVENT_INACTIVITY_TIMEOUT)
I tracked it down to fadddc, and to do the revert I also had to back out a few changes from b6f422
The crash would be triggered within a few minutes of running synthetic-production traffic. With this revert I ran for 30 minutes and never got the crash