Skip to content

Conversation

@jrushford
Copy link
Contributor

Updates to parent selection for multi origin features.

@jpeach
Copy link
Contributor

jpeach commented Jan 22, 2016

It's better to rebase your branch than to merge master into it. Rebating keeps the history cleaner and makes it easier to see what happened on a branch.

@jpeach
Copy link
Contributor

jpeach commented Jan 22, 2016

Actually you can have simple retry and dead server retry enabled at the same time

Sure, but not in the same transaction. The transaction override would be to set the policy. For example, it is not obvious to an operator what the behavior should be if both policies were enabled at the same time. If there is a single configuration setting this situation cannot arise.

The parsing of the response code string is because all the settings are overridable by delivery service.

Sure, but in the common case, the settings can be parsed once and reused for many transactions. You don't even need to parse them in the context of the HTTP transaction, you can do the parsing in the configuration override API.

@jrushford jrushford force-pushed the ts4115 branch 4 times, most recently from 298cfee to 3a115d5 Compare February 10, 2016 20:18
@jrushford jrushford force-pushed the ts4115 branch 2 times, most recently from 8ae4b7e to a717091 Compare February 12, 2016 17:50
@jpeach
Copy link
Contributor

jpeach commented Feb 12, 2016

Thanks @jrushf1239k, I'll review over the weekend.

@jrushford jrushford force-pushed the ts4115 branch 6 times, most recently from 7d06d49 to 93f0f2a Compare February 23, 2016 16:07
@bryancall
Copy link
Contributor

Talking at the github meeting. The consensus is that we should split the pull request into two pull requests. One for multi origin and the other for retry logic.

We should also have the configuration in parent.config instead of records.config.

@jrushford
Copy link
Contributor Author

Submitting another pull request with only changes for multi-site origin.

@jrushford jrushford closed this Feb 29, 2016
@jrushford jrushford deleted the ts4115 branch April 5, 2016 22:08
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Apr 13, 2017
apache#407)

* Backport https://partner.git.corp.yahoo.com/Edge/trafficserver/pull/405 from 7.1. to 5.3.x
(cherry picked from commit 80dd670)

* Probably is supposed to be BUILD_TSTOP
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request May 10, 2021
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request May 10, 2021
masaori335 added a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
…he#407)

This adds back in the scheme and wire protocol check (see apache#8465) along
with a configuration to be able to disable the check if the verification
is not desired.

(cherry picked from commit 644d94b1472d7816a83ecbb2ddbc9c0afcedd346)

Co-authored-by: Brian Neradt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants