-
Notifications
You must be signed in to change notification settings - Fork 852
TS-4115: add multi origin feature to parent selection. #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's better to rebase your branch than to merge master into it. Rebating keeps the history cleaner and makes it easier to see what happened on a branch. |
Sure, but not in the same transaction. The transaction override would be to set the policy. For example, it is not obvious to an operator what the behavior should be if both policies were enabled at the same time. If there is a single configuration setting this situation cannot arise.
Sure, but in the common case, the settings can be parsed once and reused for many transactions. You don't even need to parse them in the context of the HTTP transaction, you can do the parsing in the configuration override API. |
298cfee to
3a115d5
Compare
8ae4b7e to
a717091
Compare
|
Thanks @jrushf1239k, I'll review over the weekend. |
7d06d49 to
93f0f2a
Compare
|
Talking at the github meeting. The consensus is that we should split the pull request into two pull requests. One for multi origin and the other for retry logic. We should also have the configuration in parent.config instead of records.config. |
|
Submitting another pull request with only changes for multi-site origin. |
apache#407) * Backport https://partner.git.corp.yahoo.com/Edge/trafficserver/pull/405 from 7.1. to 5.3.x (cherry picked from commit 80dd670) * Probably is supposed to be BUILD_TSTOP
… full (apache#407)" (apache#410) This reverts commit 7b096e5.
…he#407) This adds back in the scheme and wire protocol check (see apache#8465) along with a configuration to be able to disable the check if the verification is not desired. (cherry picked from commit 644d94b1472d7816a83ecbb2ddbc9c0afcedd346) Co-authored-by: Brian Neradt <[email protected]>
Updates to parent selection for multi origin features.