Fix logic to support ASYNC_pause_job #4024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
approved these changes
Jul 31, 2018
Contributor
|
This isn't applicable to the 7.1.x branch, is it ? |
Contributor
|
Cherry-picked to 8.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes I made while creating a crypto engine that really exercises the ASYNC_pause_job feature. Without these changes the Handshake logic was triggering SSL_accept before the job signaled, (e.g. the read event was on the read_ready_queue). This could our blocked job to unpause too soon and block on the job's signal read cleanup.
Since we should not be reading the client's network socket at the same time as waiting for the job signal, we just temporarily replace the client socket with the job signal socket in the epoll object.
Working on open sourcing my crypto engine with the next month.
Need PR #4020 and PR #4019 for stability fixes too.