Skip to content

[TS-3911] New log tag for proxy connection being over SSL, pqssl #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericcarlschwartz wants to merge 1 commit into from
Closed

[TS-3911] New log tag for proxy connection being over SSL, pqssl #293

ericcarlschwartz wants to merge 1 commit into from

Conversation

@ericcarlschwartz
Copy link
Contributor

@ericcarlschwartz ericcarlschwartz commented Sep 14, 2015

Have tested this and provides the correct info.

@zwoop
Copy link
Contributor

zwoop commented Sep 14, 2015

As discussed on the IRC, I think we should

  1. Change the subject for this Jira, I thought isSSL was the name of the new tag.

  2. The description should change, instead of "proxy_req_ssl_reused" it should be e.g. "proxy_req_is_ssl"

#2 is a bug in a previous patch, so we should fix that as well, for the "cqssl" tag.

@ericcarlschwartz ericcarlschwartz changed the title [TS-3911] Create log tag for server connection isSSL [TS-3911] Create log tag for whether proxy to server connection is ssl Sep 14, 2015
ericcarlschwartz
ericcarlschwartz reviewed Sep 14, 2015
View reviewed changes
proxy/logging/Log.cc
Copy link
Contributor Author

@ericcarlschwartz ericcarlschwartz Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zwoop this look good?

Copy link
Contributor

@zwoop zwoop Sep 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ericcarlschwartz ericcarlschwartz changed the title [TS-3911] Create log tag for whether proxy to server connection is ssl [TS-3911] New log tag for proxy connection being over SSL, pqssl Sep 14, 2015
@asfgit asfgit closed this in 0a58767 Sep 21, 2015
SolidWallOfCode pushed a commit to SolidWallOfCode/trafficserver that referenced this pull request Feb 1, 2017
@shinrich
Merge pull request apache#293 from Edge/ytsats-969
a2ca430 
YTSATS-969: NULL mutex crash in HTTP2
bneradt pushed a commit to bneradt/trafficserver that referenced this pull request Nov 19, 2020
@shinrich
Merge pull request apache#293 from feid/9.0.x-fix_revert
6a36977 
YTSATS-3368: revert YTSATS-3008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericcarlschwartz @zwoop