Limit maximum size ATS can read from net at a time in SSL read loop#2247
Closed
maskit wants to merge 1 commit intoapache:masterfrom
Closed
Limit maximum size ATS can read from net at a time in SSL read loop#2247maskit wants to merge 1 commit intoapache:masterfrom
maskit wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
I don't think the value should be hardcoded. Using loop count is an option too. The point is that we need to break out from this loop somehow without any errors at times. |
Member
Member
|
The NetHandler is designed to:
After #629 merged, the |
oknet
requested changes
Jul 7, 2017
| } | ||
| int64_t block_write_avail = buf.writer()->block_write_avail(); | ||
| if (block_write_avail <= 0) { | ||
| buf.writer()->add_block(); |
Member
There was a problem hiding this comment.
Whether or not add a new block , It is controlled by the watermark of MIOBuffer.
Just break out here if buf.write_avail() less than 0.
Member
Author
|
Thanks for the comments. Discussion will be continued on #2248. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit maximum size ATS can read from net at a time in SSL read loop. Hopefully avoids timeouts during POST.