Skip to content

coverity 1021924: Missing break in switch#1780

Merged
gtenev merged 1 commit intoapache:masterfrom
gtenev:coverity_1021924
May 8, 2017
Merged

coverity 1021924: Missing break in switch#1780
gtenev merged 1 commit intoapache:masterfrom
gtenev:coverity_1021924

Conversation

@gtenev
Copy link
Contributor

@gtenev gtenev commented May 8, 2017

Problem:
CID 1021924 (#1 of 1): Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value TS_EVENT_VCONN_WRITE_READY is not terminated by a 'break' statement.

Solution:
It was intended not to have a break (not a bug), so refactored the code to make coverity happy.

Problem:
  CID 1021924 (#1 of 1): Missing break in switch (MISSING_BREAK)
  unterminated_case: The case for value TS_EVENT_VCONN_WRITE_READY is not terminated by a 'break' statement.

Solution:
  It was intended not to have a break (not a bug), so refactored the code to make coverity happy.
@atsci
Copy link

atsci commented May 8, 2017

@atsci
Copy link

atsci commented May 8, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/389/

@atsci
Copy link

atsci commented May 8, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2072/

@atsci
Copy link

atsci commented May 8, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/502/

@atsci
Copy link

atsci commented May 8, 2017

@atsci
Copy link

atsci commented May 8, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1965/

@atsci
Copy link

atsci commented May 8, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/635/

@gtenev gtenev added the Coverity label May 8, 2017
@bryancall bryancall added this to the 8.0.0 milestone May 8, 2017
@gtenev
Copy link
Contributor Author

gtenev commented May 8, 2017

[approve ci]

@atsci
Copy link

atsci commented May 8, 2017

@atsci
Copy link

atsci commented May 8, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/390/

@bryancall bryancall self-requested a review May 8, 2017 17:13
@gtenev gtenev merged commit 98860a7 into apache:master May 8, 2017
@gtenev gtenev deleted the coverity_1021924 branch May 8, 2017 17:15
@atsci
Copy link

atsci commented May 8, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/2073/

@atsci
Copy link

atsci commented May 8, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/503/

@atsci
Copy link

atsci commented May 8, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1966/

@atsci
Copy link

atsci commented May 8, 2017

@atsci
Copy link

atsci commented May 8, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/636/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants