hrw: forward declare template specializations#12456
Merged
cmcfarlen merged 4 commits intoapache:masterfrom Aug 19, 2025
Merged
Conversation
Member
|
Looks good to me. I'll close #12433. |
bneradt
reviewed
Aug 15, 2025
| endif() | ||
|
|
||
| add_executable(test_matcher matcher_tests.cc matcher.cc lulu.cc regex_helper.cc resources.cc) | ||
| add_test(NAME test_matcher COMMAND $<TARGET_FILE:test_matcher>) |
Contributor
There was a problem hiding this comment.
It would be nice to land #12453 so we don't conflict with these.
bneradt
previously approved these changes
Aug 15, 2025
Contributor
|
[approve ci] |
Contributor
|
Here's the ubuntu build failure: |
bneradt
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older (but not that old) compiler's can't see template specializations implemented in another translation unit without forward declaring them. This adds the forward declarations and also adds a unit test that was used to track down and verify this issue.
This is an alternative fix to #12433