Extract class AggregateWriteBuffer from Stripe#10718
Merged
bneradt merged 2 commits intoapache:masterfrom Nov 15, 2023
Merged
Conversation
9ce3b05 to
963699f
Compare
Contributor
Author
|
HostDB regression test failed on Ubuntu and CentOS and AuTests |
Contributor
Author
|
I will rebase and mark ready for review after #10710 lands. |
masaori335
reviewed
Nov 7, 2023
be1eec6 to
0f53246
Compare
This encapsulates the `agg_` fields of `Stripe` in a new class. This is in preparation to move all the aggregation behavior into this new class, including the behavior to enqueue virtual connections and update the number of bytes waiting to be written to the buffer, which is currently being done by the virtual connections themselves. Note: `Stripe` does not use its own getters to access aggregate buffer, but calls the getters on the `AggregateWriteBuffer` itself. This is because I want to get rid of as many of the getters on `Stripe` as possible.
0f53246 to
81e0215
Compare
masaori335
approved these changes
Nov 14, 2023
phongn
pushed a commit
to phongn/trafficserver
that referenced
this pull request
Nov 16, 2023
This encapsulates the `agg_` fields of `Stripe` in a new class. This is in preparation to move all the aggregation behavior into this new class, including the behavior to enqueue virtual connections and update the number of bytes waiting to be written to the buffer, which is currently being done by the virtual connections themselves. Note: `Stripe` does not use its own getters to access aggregate buffer, but calls the getters on the `AggregateWriteBuffer` itself. This is because I want to get rid of as many of the getters on `Stripe` as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This encapsulates the
agg_fields ofStripein a new class. This is in preparation to move all the aggregation behavior into this new class, including the behavior to enqueue virtual connections and update the number of bytes waiting to be written to the buffer, which is currently being done by the virtual connections themselves.Note:
Stripedoes not use its own getters to access aggregate buffer, but calls the getters on theAggregateWriteBufferitself. This is because I want to get rid of as many of the getters onStripeas possible.