Skip to content

CID-1512733: Fix coverity issue #10452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brbzull0 merged 1 commit into from
Sep 19, 2023
Merged

CID-1512733: Fix coverity issue #10452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/traffic_ctl/CtrlPrinters.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@ ConfigShowFileRegistryPrinter::write_output(YAML::Node const &result)
void
ConfigSetPrinter::write_output(YAML::Node const &result)
{
static const std::unordered_map<std::string, std::string> Update_Type_To_String_Message = {
using TypeToStringMap = std::unordered_map<std::string, std::string>;
static const TypeToStringMap Update_Type_To_String_Message = {
{"0", "Set {}" }, // UNDEFINED
{"1", "Set {}, please wait 10 seconds for traffic server to sync configuration, restart is not required"}, // DYNAMIC
{"2", "Set {}, restart required" }, // RESTART_TS
Expand All @@ -190,8 +191,8 @@ ConfigSetPrinter::write_output(YAML::Node const &result)
try {
auto const &response = result.as<ConfigSetRecordResponse>();
for (auto &&updatedRec : response.data) {
if (auto search = Update_Type_To_String_Message.find(updatedRec.updateType);
search != std::end(Update_Type_To_String_Message)) {
TypeToStringMap::const_iterator search = Update_Type_To_String_Message.find(updatedRec.updateType);
if (search != std::end(Update_Type_To_String_Message)) {
std::cout << swoc::bwprint(text, search->second, updatedRec.recName) << '\n';
} else {
std::cout << "Oops we don't know how to handle the update status for '" << updatedRec.recName << "' ["
Expand Down