Don't set port number as part of hostname#10386
Merged
maskit merged 2 commits intoapache:masterfrom Sep 11, 2023
Merged
Conversation
Member
Author
|
@treak Basically what we discussed today. I added IPv6 support. |
traeak
approved these changes
Sep 11, 2023
Contributor
traeak
left a comment
There was a problem hiding this comment.
This should take care of the ipv6 host/port setting issue.
Contributor
|
Cherry-picked to v9.2.x |
zwoop
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Don't set port number as part of hostname * Initialize host_len with 0 (cherry picked from commit 9433581)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Sep 26, 2023
* Don't set port number as part of hostname * Initialize host_len with 0 (cherry picked from commit 9433581)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Don't set port number as part of hostname (apache#10386) JSONRPC handler: Add check for the lifecycle hooks. (apache#10312) Removes all HostDB persistent storage (apache#10368) Restores the traffic_server option for --maxRecords (apache#10388) URL.cc: url_length_get consider ipv6 address with added [] (apache#10387) make alternate tests wait a multiple of cache_config_mutex_retry_delay (apache#10378)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of autest failed on #10304 , and it discovered that there is a place mishandling Host header value.
The original code used the entire Host header value as a hostname, and it confused
url_print()because "hostname" contains a colon.url_print()treated the hostname as IPv6 address and it added brackets to the hostname like[foo.example:8888]. If it's used in an URL (i.e.http://[foo.example:8888]/), it means/will be read as an (invalid) IPv6 addressfoo.exmample:8080and port80.This PR fix the issue. The behavior is described in the comments.