This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Get build number from BUILD_NUMBER file if not in a repo#7922
Merged
rimashah25 merged 2 commits intoapache:masterfrom Jan 24, 2024
Merged
Get build number from BUILD_NUMBER file if not in a repo#7922rimashah25 merged 2 commits intoapache:masterfrom
rimashah25 merged 2 commits intoapache:masterfrom
Conversation
4 tasks
13c81fc to
372cb6b
Compare
Member
Author
|
Rebased onto 4b6af89 |
372cb6b to
4db8c5a
Compare
knutsel
approved these changes
Jan 24, 2024
Member
knutsel
left a comment
There was a problem hiding this comment.
LGTM - tested this Makefile by putting it in the previous 8.0.0 release and I know have a running CDN-in-a-Box!
Thanks!
rimashah25
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Break $(shell) function into multiple lines for readability * Get build number from BUILD_NUMBER file if not in a git repo (cherry picked from commit 13488f8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7921 by making the CDN in a Box makefile fall back to getting the build number fro the
BUILD_NUMBERfile that is generated for releases if the traffic control directory is not a git repository.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Confirm the makefile works without a git repo:
mv .git .git.moved cd infrastructure/cdn-in-a-box make traffic_ops/traffic_ops.rpmIf this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist