Skip to content

Added support for Vertica Grains#515

Merged
mistercrunch merged 1 commit into
apache:masterfrom
shopkick:Vertica
Jun 1, 2016
Merged

Added support for Vertica Grains#515
mistercrunch merged 1 commit into
apache:masterfrom
shopkick:Vertica

Conversation

@LAlbertalli

Copy link
Copy Markdown
Contributor

Added support for HP Vertica

Vertica works with Caravel using the proper SQLAlchemy dialects (The original dialects has a problem with reflection https://github.com/LAlbertalli/vertica-sqlalchemy).
This patch adds the time grains specifications (from PgSQL) needed to do time aggregate.

@coveralls

coveralls commented May 25, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.006%) to 82.172% when pulling 5dfcce5 on LAlbertalli:Vertica into 7d27692 on airbnb:master.

@landscape-bot

Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 5dfcce5 on LAlbertalli:Vertica into 7d27692 on airbnb:master.

@mistercrunch

Copy link
Copy Markdown
Member

For the record, which one is the working lib/dialect?

@mistercrunch

Copy link
Copy Markdown
Member

Thanks for the PR btw!

@mistercrunch
mistercrunch merged commit ae7fb01 into apache:master Jun 1, 2016
@LAlbertalli

Copy link
Copy Markdown
Contributor Author

The original dialect is not working (It is using an old version of SQLAlchemy). My version works fine for the SQLAlchemy version used in Caravel.

mistercrunch pushed a commit that referenced this pull request Jun 2, 2016
* Created migration to fix the bug

* Working also on MySQL

* Added support for Vertica Grains (#515)

* Fix #529 1 "This Session's transaction has been rolled back" (#530)

* Fixing the specific issue

* Added an additional fix for a similar error in #529

Background:
- When an object is modified by SQLAlchemy, it is invalidated so need to be fetched again from the DB
- If there's an exception during a transaction, SQLAlchemy performs a rollback and mark the connection as dirty.

Bug:
- When handling exceptions, the exception handler tries to access the name of the cluster in the main object. Since the name has been invalidated due to a write, SQLAlchemy tries to fetch it on a 'dirty' connection and spits out an error. Solution:
- Fetch the information for handling the exception before starting the process.

* Modified the migration function to to automatically detect the the foreign keys based on the signature.
It supports also sqlite using batch migrations

* i18n: Fix typo in Druid cluster broker port label (#512)

* Update models.py (#541)

removing duplicated `user_id` def
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 First shipped in 0.9.1 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 First shipped in 0.9.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants