Skip to content

fix(helm): Add common labels for init job pods - #31346

Closed
LipuFei wants to merge 1 commit into
apache:masterfrom
LipuFei:chart/add-label-for-init-job
Closed

fix(helm): Add common labels for init job pods#31346
LipuFei wants to merge 1 commit into
apache:masterfrom
LipuFei:chart/add-label-for-init-job

Conversation

@LipuFei

@LipuFei LipuFei commented Dec 9, 2024

Copy link
Copy Markdown

Add two common labels for the init-job pods, similar to other deployments.

In our environment, we need to define NetworkPolicies to control network traffic. Without labels on the init-job pods, I cannot whitelist any network traffic for them.

@LipuFei LipuFei changed the title fix(helm): Add common labels for init job fix(helm): Add common labels for init job pods Dec 9, 2024
@dosubot dosubot Bot added the deploy:helm label Dec 9, 2024

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@villebro

villebro commented Dec 9, 2024

Copy link
Copy Markdown
Member

@LipuFei thanks for the PR, but we just merged #30956 that fixes this. So I'm closing this PR, as this is already done.

@villebro villebro closed this Dec 9, 2024
@LipuFei

LipuFei commented Dec 9, 2024

Copy link
Copy Markdown
Author

@villebro No worries. :) Glad to see it's fixed.

@LipuFei
LipuFei deleted the chart/add-label-for-init-job branch December 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants