Skip to content

fix(Dashboard): Exclude edit param in async screenshot#30962

Merged
geido merged 1 commit into
masterfrom
geido/fix/edit-param-dashboard-screenshot
Nov 18, 2024
Merged

fix(Dashboard): Exclude edit param in async screenshot#30962
geido merged 1 commit into
masterfrom
geido/fix/edit-param-dashboard-screenshot

Conversation

@geido

@geido geido commented Nov 18, 2024

Copy link
Copy Markdown
Member

SUMMARY

This PR #30675 introduced a way to pass urlParams to the async dashboard screenshot generation endpoint. However, edit was an acceptable value which caused the system to take a screenshot in edit mode of a newly created dashboard. This PR fixes that.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Create a new dashboard
  2. Download the dashboard screenshot as PDF
  3. The screenshot should not be showing the dashboard in edit mode

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ENABLE_DASHBOARD_SCREENSHOT_ENDPOINTS ENABLE_DASHBOARD_DOWNLOAD_WEBDRIVER_SCREENSHOT
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
geido requested a review from Vitor-Avila November 18, 2024 14:13
@dosubot dosubot Bot added dashboard:editmode Related to te Dashboard edit mode dashboard:export Related to exporting dashboards labels Nov 18, 2024
Vitor-Avila
Vitor-Avila approved these changes Nov 18, 2024
View reviewed changes

@Vitor-Avila Vitor-Avila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this! 🙏

@geido
geido merged commit 1b63b8f into master Nov 18, 2024
asher-lab added a commit to asher-lab/superset that referenced this pull request Nov 22, 2024
@asher-lab @michael-s-molina
@sadpandajoe @mistercrunch @msyavuz @geido @villebro @PaoloTerzi @samarsrivastav @rusackas @amotl @LevisNgigi @dependabot @eschutho @theoriginalgri @lodu @betodealmeida @github-actions @actions-user @justinpark @dimbleby @jpchev @lindenh @seiyab Asher Manangan
fix(import): Merge apache/master and resolve conflicts (#20)
8b446df 
* fix: Exception handling for SQL Lab views (apache#30897)

* fix: don't show metadata for embedded dashboards (apache#30875)

* feat: add logging durations for screenshot async service (apache#30884)

* refactor(Avatar): Migrate Avatar to Ant Design 5 (apache#30740)

* refactor(input): Migrate Input component to Ant Design 5 (apache#30730)

* fix(empty dashboards): Allow downloading a screenshot of an empty dashboard (apache#30767)

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* chore(ci): add tai and michael to helm owners (apache#30925)

* fix(helm): use submodule on helm release action (apache#30924)

* docs: add Free2Move to INTHEWILD.md (apache#30930)

* fix: blocks UI elements on right side (apache#30886)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(deps): Migrate from `crate[sqlalchemy]` to `sqlalchemy-cratedb` (apache#29243)

* chore: update change log, UPDATING.md and bug-report.yml for 4.1 release (apache#30915)

* chore(docs): Update list of supported databases to include CrateDB (apache#30946)

* feat(trino,presto): add missing time grains (apache#30926)

* fix(Dashboard): Exclude edit param in async screenshot (apache#30962)

* fix(Card): Use correct class names for Ant Design 5 Card component (apache#30964)

* chore(Accessibility): Fix accessibility for 'Show x entries' dropdown in tables (apache#30818)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /superset-frontend/cypress-base (apache#30969)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(release validation): scripts now support RSA and EDDSA keys. (apache#30967)

* build(deps): bump cross-spawn from 7.0.3 to 7.0.6 in /docs (apache#30970)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: add performance information to tooltip (apache#30948)

* fix(helm-chart): Fix broken PodDisruptionBudget due to introduction of extraLabels. (apache#30966)

* chore(helm): bumping app version to 4.1.1 in helm chart (apache#30918)

* chore: add unit tests for `is_mutating()` (apache#31021)

* chore(🦾): bump python numexpr 2.10.0 -> 2.10.1 (apache#31006)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python cffi 1.16.0 -> 1.17.1 (apache#31002)

Co-authored-by: GitHub Action <action@github.com>

* chore(🦾): bump python flask-babel subpackage(s) (apache#31000)

Co-authored-by: GitHub Action <action@github.com>

* fix(Dashboard): Retain colors when color scheme not set (apache#30646)

* fix(explore): verified props is not updated (apache#31008)

* chore: publish wheels (apache#30981)

* docs: Embedded sdk (apache#30972)

* fix(imports): import query_context for imports with charts (apache#30887)

* docs: Update doc about CSV upload (apache#30867)

Co-authored-by: Evan Rusackas <evan@preset.io>

* chore(🦾): bump python cattrs 23.2.3 -> 24.1.2 (apache#30998)

Co-authored-by: GitHub Action <action@github.com>

* fix(dataset): use sqlglot for DML check (apache#31024)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Joe Li <joe@preset.io>
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Paolo Terzi <PaoloTerzi@users.noreply.github.com>
Co-authored-by: Sukuna <90980311+samarsrivastav@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Andreas Motl <andreas.motl@elmyra.de>
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Co-authored-by: Levis Mbote <111055098+LevisNgigi@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Christoph Keller <github@christophkeller.cc>
Co-authored-by: lodu <48859312+lodu@users.noreply.github.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: JUST.in DO IT <justin.park@airbnb.com>
Co-authored-by: David Hotham <david.hotham@microsoft.com>
Co-authored-by: Giampaolo Capelli <giampaolo.capelli@gmail.com>
Co-authored-by: Linden <zairrow@gmail.com>
Co-authored-by: Seiya <20365512+seiyab@users.noreply.github.com>
Co-authored-by: Asher Manangan <amanangan@powercosts.com>
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 22, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 22, 2024
@geido @sadpandajoe
fix(Dashboard): Exclude edit param in async screenshot (#30962)
cc0ed0f 
(cherry picked from commit 1b63b8f)
@github-actions github-actions Bot added 🍒 4.1.2 Cherry-picked to 4.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 24, 2025
@mistercrunch mistercrunch added 🍒 4.1.3 Cherry-picked to 4.1.3 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
@rusackas
rusackas deleted the geido/fix/edit-param-dashboard-screenshot branch August 12, 2025 22:59
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
@geido
fix(Dashboard): Exclude edit param in async screenshot (apache#30962)
4fcf099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antonio-RiveroMartnez Antonio-RiveroMartnez Antonio-RiveroMartnez approved these changes
@Vitor-Avila Vitor-Avila Vitor-Avila approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:editmode Related to te Dashboard edit mode dashboard:export Related to exporting dashboards size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.2 Cherry-picked to 4.1.2 🍒 4.1.3 Cherry-picked to 4.1.3 🍒 4.1.4 🚢 5.0.0 First shipped in 5.0.0

Projects

No open projects
Apache Superset 4.1.2
Status: Cherried

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geido @Antonio-RiveroMartnez @Vitor-Avila @mistercrunch @sadpandajoe