feat(helm-chart): Add extraLabels to all resources - #30710
Conversation
villebro
left a comment
There was a problem hiding this comment.
I like this idea. However, while I kind of like the global prefix, I'm wondering if it may be unnecessary. I believe we may already have some other global-like values that would seem non-global after this change. But I'm not super opinionated here.
Anyway, the main comment here applies to the labels not applying to the templates. Let's either apply them to those, too, or add a comment that they're not covered by this new property.
I agree with your comment, the global label can be misleading indeed. |
villebro
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvement 🙇
|
Oh, please bump the version! |
nice catch! completely forgot 🙈 |
|
Seems there's a linting issue: |
|
@villebro fixed. Sorry for the delay |
apache#30710 introduced extraLabels but broke the PodDisruptionBudgets due to pdb configs using "with" statements. This is not catched by the linting since linting only checks with default values.
SUMMARY
Some orgs require all Kubernetes resources to be labeled. Adding a non-breaking change that will allow our team to use Superset helm chart without having to copy/paste and modify it ourselves.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION