Skip to content

fix(cross-filters): Fix missed metadata - #14220

Merged
villebro merged 3 commits into
apache:masterfrom
simcha90:fix_missed_metadata
Apr 18, 2021
Merged

fix(cross-filters): Fix missed metadata#14220
villebro merged 3 commits into
apache:masterfrom
simcha90:fix_missed_metadata

Conversation

@simcha90

@simcha90 simcha90 commented Apr 18, 2021

Copy link
Copy Markdown
Contributor

SUMMARY

When dashboardInfo -> metadata field missed in redux
It crashes for new dashboards with FF FeatureFlag.DASHBOARD_CROSS_FILTERS enabled

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
villebro merged commit c01f810 into apache:master Apr 18, 2021
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Apr 19, 2021
* master:
  fix: Use utils.json_iso_dttm_ser to dump jsons when async query execution (apache#13830)
  feat: TrinoEngineSpec.adjust_database_uri (apache#14122)
  chore: bump package.json (apache#14222)
  Add superset helm repository (apache#14223)
  fix(cross-filters): Fix missed metadata (apache#14220)
@junlincc junlincc added the dashboard:cross-filters Related to the Dashboard cross filters label Apr 27, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix:fix get permission function

* fix: fix missed metadata case
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* fix:fix get permission function

* fix: fix missed metadata case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:cross-filters Related to the Dashboard cross filters size/XS v1.2 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants