ci: use git submodules for Chart Actions#14211
Merged
Merged
Conversation
Contributor
Author
|
@amitmiran137 @craig-rueda |
Contributor
Author
|
Lint works great now. Should be OK to merge |
Member
|
Again , the work your doing here is amazing!! |
Member
|
Apache just approved the action added in #14163 . Closing this in favor of previous PR. |
Member
|
After testing, I think this is a better solution, as it doesn't require additional approvals from Apache infra :) |
craig-rueda
approved these changes
Apr 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* Add chart-action submodules * use local github actions for chart actions * Run actions checkout for local checkout * Run lint when PR is edited * Remove path filter and dummy value * Fix fetch-depth * Test chart version bump * Update maintainer to pass validation * Update maintainer to pass validation
This was referenced Oct 5, 2024
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* Add chart-action submodules * use local github actions for chart actions * Run actions checkout for local checkout * Run lint when PR is edited * Remove path filter and dummy value * Fix fetch-depth * Test chart version bump * Update maintainer to pass validation * Update maintainer to pass validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds chart actions submodules to allow chart actions to run.
Added because of implementation for using git submodules for (securely) using third party Github Actions (#12709)
Related to #14163 that has been accepted.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
@craig-rueda