fix: refresh dashboard list after bulk delete - #12945
Merged
rusackas merged 1 commit intoFeb 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12945 +/- ##
==========================================
+ Coverage 53.17% 61.87% +8.69%
==========================================
Files 449 545 +96
Lines 14826 20138 +5312
Branches 3959 5265 +1306
==========================================
+ Hits 7884 12460 +4576
- Misses 6942 7465 +523
- Partials 0 213 +213
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
Can we add a test for this change? |
nytai
approved these changes
Feb 4, 2021
junlincc
self-requested a review
February 4, 2021 21:01
Member
|
@michael-s-molina yes, please do add test, thanks Michael! @amitmiran137 @simcha90 when i tried to bulk delete a dashboard that i gave access to gamma users, it threw an error. it worked when I delete just the one dashboard. can you open a PR to handle this edge case? thanks |
michael-s-molina
force-pushed
the
fix-dashboard-bulk-delete
branch
from
February 5, 2021 14:07
727e48f to
07ace8a
Compare
Member
Author
|
@willbarrett @junlincc Tests added. |
michael-s-molina
force-pushed
the
fix-dashboard-bulk-delete
branch
from
February 5, 2021 16:00
07ace8a to
45488d3
Compare
michael-s-molina
force-pushed
the
fix-dashboard-bulk-delete
branch
from
February 8, 2021 19:38
45488d3 to
0e5ac04
Compare
amitmiran137
pushed a commit
to simcha90/incubator-superset
that referenced
this pull request
Feb 10, 2021
* master: fix: UI toast typo (apache#13026) feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602) fix(build): black failing on master, add to required checks (apache#13039) fix: time filter db migration optimization (apache#13015) fix: untranslated text content of Dashboard page (apache#13024) fix(ci): remove signature requirements for commits to master (apache#13034) fix: add alerts and report to default config (apache#12999) docs(changelog): add entries for 1.0.1 (apache#12981) ci: skip cypress if no code changes (apache#12982) chore: add cypress required checks for branch protection (apache#12970) Refresh dashboard list after bulk delete (apache#12945) Updates storybook to version 6.1.17 (apache#13014) feat: Save datapanel state in local storage (apache#12996) fix: added text and changed margins (apache#12923) chore: Swap Slack Url 2 more places (apache#13004)
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Refresh dashboard list after bulk delete.
@junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
1 - Go to dashboad list
2 - Delete an item using bulk delete
3 - The item should be deleted and the list refreshed
ADDITIONAL INFORMATION