chore: rename duplicate build jobs - #12921
Merged
Merged
Conversation
Member
Author
ktmud
reviewed
Feb 3, 2021
ktmud
left a comment
Member
There was a problem hiding this comment.
Wdyt of limiting this PR to only renaming jobs and saving the addition of more jobs in context to another PR?
| contexts: | ||
| - check | ||
| - lint | ||
| - test-mysql |
Member
There was a problem hiding this comment.
I think we may need to append python version to test-mysql as well. E.g. test-mysql (3.7).
It seems GitHub checks uses the job name with matrix variables.
Member
Author
|
@ktmud feel free to merge when ready if this looks good to you. |
6 tasks
amitmiran137
approved these changes
Feb 3, 2021
ktmud
approved these changes
Feb 4, 2021
This was referenced Feb 5, 2021
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
On #12694 we started moving some required checks to the new .asf.yaml config that Apache provides. We started by testing just one job so that we could verify that it worked and we didn't inadvertently block any jobs by using the wrong job name. We have tested that the file is working, but there are some checks with duplicate names. This pr renames the duplicate jobs. In a subsequent PR(s), I will add the rest of the checks with the new job names.
TEST PLAN
Verify that master requires the new jobs when this merges.
ADDITIONAL INFORMATION