Skip to content

chore: add required review on master #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktmud merged 6 commits into from
Feb 3, 2021
Merged

chore: add required review on master #12694

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9701816
add required review on master
eschutho Jan 22, 2021
c057787
update to include all items in required reviews
eschutho Jan 22, 2021
53aac66
change value on dismiss stale reviews
eschutho Jan 22, 2021
9e9bb9a
add more action names to checks
eschutho Jan 23, 2021
26c6957
add just one required action to test
eschutho Jan 27, 2021
97b93c2
use job name
eschutho Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .asf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,17 @@ github:
squash: true
merge: false
rebase: false

protected_branches:
master:
required_status_checks:
# strict means "Require branches to be up to date before merging".
strict: false
# contexts are the names of checks that must pass
contexts:
- check

required_pull_request_reviews:
dismiss_stale_reviews: false
require_code_owner_reviews: true
required_approving_review_count: 1

@eschutho eschutho Jan 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely would like a second pair of eyes on all this. I don't think there's a way to test before merging.

@nytai nytai Jan 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only risk I see is the contexts are not correct. Let's just be ready to fix/revert if needed

@eschutho eschutho Jan 22, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah, I set up: #12698 and will rebase when this lands. We might as well wait until next week, too, to land this.