feat: default timepicker to last week when dataset is changed#12609
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12609 +/- ##
==========================================
+ Coverage 62.77% 66.66% +3.89%
==========================================
Files 1015 1022 +7
Lines 49537 49999 +462
Branches 5079 4894 -185
==========================================
+ Hits 31096 33333 +2237
+ Misses 18232 16541 -1691
+ Partials 209 125 -84
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pkdotson
marked this pull request as ready for review
January 22, 2021 18:18
Member
|
@pkdotson
Screen.Recording.2021-01-22.at.10.56.39.PM.mov |
junlincc
self-requested a review
January 23, 2021 07:02
junlincc
reviewed
Jan 25, 2021
junlincc
left a comment
Member
There was a problem hiding this comment.
changes LGTM, thank you Phillip!
et's move forward with rest of the controls - changing dataset clear all previous input.
zhaoyongjie
approved these changes
Jan 26, 2021
Comment on lines
+227
to
+228
| setTimeRangeValue('Last week'); | ||
| setFrame(guessFrame('Last week')); |
Member
There was a problem hiding this comment.
These two lines can be removed. Because when the value changed(onChange('last week')) then the component can reload.
Member
There was a problem hiding this comment.
Sorry. Ignore me. Shouldn't be removed. merged.
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 26, 2021
* master: (52 commits) docs: Updates to Superset Site for 1.0 (apache#12626) test(native-filters): scoping tree in native filters modal (apache#12655) Fix tests errors and warnings - iteration 3 (apache#12212) (apache#12219) Fix tests errors and warnings - iteration 5 (apache#12212) (apache#12224) Fix tests errors and warnings - iteration 6 (apache#12212) (apache#12227) feat(native-filters): apply scoping of native filters to dashboard (apache#12716) Fix tests errors and warnings - iteration 4 (apache#12212) (apache#12223) Fix tests errors and warnings - iteration 7 (apache#12212) (apache#12245) fix: missing select menu background (apache#12759) fix(explore): incorrect missing datasource condition (apache#12758) feat: default timepicker to last week when dataset is changed (apache#12609) feat(explore): allow opening charts with missing dataset (apache#12705) chore: upgrade Cypress to 6.2.1 (apache#12605) refactor(explore): Enhance Dataset and Control panel Collapse components (apache#12218) feat: Adding option to set_database_uri CLI command (apache#12740) docs: Fixed typo on line 348 (apache#12739) Fix tests errors and warnings - iteration 2 (apache#12212) (apache#12214) docs: Remove gatsby-plugin-offline (apache#12693) test: oracle engine spec (apache#12615) test: hive db engine spec (apache#12520) ...
6 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…#12609) * set up timepicker to last when dataset is changed * simplify logic for dataset change * update modal code * remove uneeded code * fix bug * fix bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pr defaults the time picker in chart control panel to last week when user changes dataset. This is the first step in setting up the controls for metrics to default to empty states when user changes datasets.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-01-22.at.3.36.21.PM.mov
TEST PLAN
Currently manually testing and updating related tests as necessary.
ADDITIONAL INFORMATION