test: add React Testing Library#11771
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11771 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 905 905
Lines 43862 43862
Branches 4201 4201
=======================================
Hits 29519 29519
Misses 14239 14239
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ktmud
requested review from
etr2460,
graceguo-supercat,
kristw,
nytai and
rusackas
November 24, 2020 05:47
ktmud
force-pushed
the
add-react-testing-library
branch
from
November 24, 2020 05:48
362417d to
ae3f033
Compare
6 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implement [SIP-56] Adopt React Testing Library for testing React components.
As demonstrated in the new code, with RTL, we are able to easily test the use of the
useEffecthook with DOM updates, that is previously not possible to do in Enzyme. Just make sure to use waitFor to wait for the DOM change, otherwise you may encounteran update inside a test was not wrapped in act(...)errors.Another lesson learned is that in order to use
waitFor, you must explicitly add ajest-environment: jsdomdocblock to the test file, because the default jest environmentjest-enzymeis incompatible with RTL.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI
ADDITIONAL INFORMATION