[SPARK-11792] remove blockManager from BytesToBytesMap#9799
Closed
davies wants to merge 1 commit into
Closed
Conversation
|
Test build #46191 has finished for PR 9799 at commit
|
Contributor
|
Just curious: might it be less brittle to implement the new size estimation interface instead, since we should be able to figure out the size exactly? |
Contributor
|
+1 to @JoshRosen's suggestion, which is actually @davies' original proposal. Even though we don't use broadcast |
Contributor
Author
|
Since this is not the approach everybody like, and SPARK-11792 is already resolved, I'd close this PR for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BytesToBytesMap will be used by UnsafeHashRelation, and stored in memory store, then SizeEstimator will see BlockManager as part of BytesToBytesMap, which is not what we expect.
This PR remove the reference to BlockManager in BytesToBytesMap, using
SparkEnv.get().blockManagerduring spilling (currently we get the blockManager in one of the constructors).cc @yhuai @rxin