[SPARK-11728] Replace example code in ml-ensembles.md using include_example#9716
Closed
yinxusen wants to merge 9 commits into
Closed
[SPARK-11728] Replace example code in ml-ensembles.md using include_example#9716yinxusen wants to merge 9 commits into
yinxusen wants to merge 9 commits into
Conversation
|
Test build #45929 has finished for PR 9716 at commit
|
Contributor
There was a problem hiding this comment.
This is different from current example code in user guide, where we use sqlContext.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt"). Please find other places and switch to using "libsvm" data source instead.
Contributor
|
LGTM except one issue commented inline. Please keep the example code the same while moving them around. It is easier for review. |
Contributor
Author
|
Fixed, sorry for the carelessness. |
|
Test build #46164 has finished for PR 9716 at commit
|
|
Test build #46162 has finished for PR 9716 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
…xample JIRA issue https://issues.apache.org/jira/browse/SPARK-11728. The ml-ensembles.md file contains `OneVsRestExample`. Instead of writing new code files of two `OneVsRestExample`s, I use two existing files in the examples directory, they are `OneVsRestExample.scala` and `JavaOneVsRestExample.scala`. Author: Xusen Yin <yinxusen@gmail.com> Closes #9716 from yinxusen/SPARK-11728. (cherry picked from commit 9154f89) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Contributor
|
Merged into master and branch-1.6. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.
The ml-ensembles.md file contains
OneVsRestExample. Instead of writing new code files of twoOneVsRestExamples, I use two existing files in the examples directory, they areOneVsRestExample.scalaandJavaOneVsRestExample.scala.