[SPARK-11732] Removes some MiMa false positives

[thunterdb]

This adds an extra filter for private or protected classes. We only filter for package private right now.

[thunterdb]

cc @pwendell @mengxr

[SparkQA]

Test build #45875 has finished for PR 9697 at commit 39a59bd.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):\n * public class JavaGradientBoostingClassificationExample\n * public class JavaGradientBoostingRegressionExample\n * public class JavaRandomForestClassificationExample\n * public class JavaRandomForestRegressionExample\n

[srowen]

You also added protected here though; I'm not sure that's safe to exclude from checks.

The point is that some previous excludes are now caught by the new isPrivate check and ignored?

[thunterdb]

After checking the scala specs, the protected modifier only affects methods, not classes. I am removing it.

[thunterdb]

About your previous question, yes, isPrivate catches some classes that we did not catch previously (because we were checking for package-private classes, not private classes).

[thunterdb]

@srowen sorry the delay. comment addressed

[SparkQA]

Test build #46006 has finished for PR 9697 at commit 69d75ab.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

LGTM @pwendell as I can't see why MiMa would need to look at private classes of any type.

[pwendell]

Yep, this LGTM

[srowen]

Merged to master/1.6

[thunterdb]

Thank you @srowen