[SPARK-40193][SQL][FOLLOWUP] Rename spark.sql.optimizer.mergeSubplans.( -> filterPropagation.)symmetricFilterPropagation.enabled#55633
Closed
dongjoon-hyun wants to merge 2 commits into
Conversation
…terPropagation.)symmetricFilterPropagation.enabled`
This was referenced Apr 30, 2026
Member
Author
|
cc @peter-toth |
dongjoon-hyun
commented
Apr 30, 2026
|
|
||
| val MERGE_SUBPLANS_SYMMETRIC_FILTER_PROPAGATION_ENABLED = | ||
| buildConf("spark.sql.optimizer.mergeSubplans.symmetricFilterPropagation.enabled") | ||
| buildConf("spark.sql.optimizer.mergeSubplans.filterPropagation.symmetricFilterPropagation.enabled") |
Member
Author
There was a problem hiding this comment.
Since we have the namespace prefix, spark.sql.optimizer.mergeSubplans.filterPropagation, already, we may want to change symmetricFilterPropagation part more specifically. Please let me know if you want to propose a better name than symmetricFilterPropagation, @peter-toth .
Contributor
There was a problem hiding this comment.
Name sounds good to me.
Member
Author
There was a problem hiding this comment.
Got it. Thank you for the confirmation.
peter-toth
approved these changes
Apr 30, 2026
Member
Author
|
Thank you, @peter-toth ~ |
Member
Author
|
Merged to master for Apache Spark 4.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames the SQL config key
spark.sql.optimizer.mergeSubplans.symmetricFilterPropagation.enabledtospark.sql.optimizer.mergeSubplans.filterPropagation.symmetricFilterPropagation.enabled.Why are the changes needed?
To follow the Apache Spark configuration namespace rule. The new key better reflects the configuration hierarchy.
spark.sql.optimizer.mergeSubplans.filterPropagation.enabledis the parent gate for filter propagation inMergeSubplans, and the symmetric variant is a sub-feature of it. Nesting the symmetric flag underfilterPropagation.*makes that relationship explicit, and groups related options together when listed alphabetically.The previous key
mergeSubplans.symmetricFilterPropagation.enabledplaced the two sibling options at different levels of the namespace, which obscured the dependency (the symmetric flag has no effect when filter propagation is disabled, as documented in the configdoc).This config was added in 4.2.0 and has not been released yet, so no backwards-compat alias is required.
Does this PR introduce any user-facing change?
No. The config has not been released yet (introduced for 4.2.0).
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7