[SPARK-53849][BUILD] Upgrade Netty to 4.2.6.Final#52552
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
Conversation
Member
Author
|
All tests passed. |
Member
Author
|
Could you review this PR when you have some time, please, @peter-toth ? |
sarutak
approved these changes
Oct 9, 2025
| -Djdk.reflect.useDirectMethodHandle=false | ||
| -Dio.netty.tryReflectionSetAccessible=true | ||
| -Dio.netty.allocator.type=pooled | ||
| -Dio.netty.handler.ssl.defaultEndpointVerificationAlgorithm=NONE |
Member
There was a problem hiding this comment.
I understand these changes are for keeping behavior like Netty 4.1 and before as the migration guides indicates.
https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide
Member
Author
|
Merged to master for Apache Spark 4.1.0-preview3. |
Contributor
|
late LGTM |
LuciferYang
reviewed
Oct 13, 2025
| TransportServer server = context.createServer(); | ||
| int unreachablePort = server.getPort(); | ||
| server.close(); | ||
| Thread.sleep(1000); |
Contributor
There was a problem hiding this comment.
@dongjoon-hyun I also noticed this problem when testing versions prior to 4.2.6. There's a slight delay when the server executes the "close" operation. Have you conducted an in-depth investigation into the reason for this? If not, I will take some time to look into it when I'm available.
Member
Author
There was a problem hiding this comment.
Ya, it's a slight change and could be configurable via some Netty confs. Since we only use this close-and-reopen pattern to get an unreachable port number in our test cases, I didn't dig the further.
Thank you, @LuciferYang . If you hit any issue, let me know. I hope we can test this via Apache Spark 4.1.0-preview3 widely.
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `Netty` to `4.2.6.Final` as a part of `Apache Spark 4.1.0` preparation. This PR follows the official community migration guide. - https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide ### Why are the changes needed? `Netty` community recommends `4.2`. > After a lot of work and many contributions from our OSS community we are thrilled to finally announce the release of netty 4.2.0.Final! Everyone using netty 4.1.x should be able to upgrade to 4.2.0.Final without any API breakage. The only new requirement is JDK8 or later (and JDK9+ for io_uring) and a more recent GLIBC version when using our native transports. - https://netty.io/news/2025/09/08/4-2-6.html - https://netty.io/news/2025/09/03/4-2-5.html - https://netty.io/news/2025/08/13/4-2-4.html - https://netty.io/news/2025/07/15/4-2-3.html - https://netty.io/news/2025/06/05/4-2-2.html - https://netty.io/news/2025/05/06/4-2-1.html - https://netty.io/news/2025/04/03/4-2-0.html ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52552 from dongjoon-hyun/SPARK-53849. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
SteNicholas
added a commit
to apache/celeborn
that referenced
this pull request
Feb 27, 2026
### What changes were proposed in this pull request? Bump Netty version from 4.1.118.Final to 4.2.10.Final, which follows the official community migration guide: [Netty-4.2-Migration-Guide](https://github.com/netty/netty/wiki/Netty-4.2-Migration-Guide). ### Why are the changes needed? The Netty 4.2.10.Final version has been released, which netty version is 4.1.118.Final at present. Backport: - apache/spark#34881 - apache/spark#52552 - apache/spark#53499 ### Does this PR resolve a correctness bug? No. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI. Closes #3596 from SteNicholas/CELEBORN-2258. Authored-by: SteNicholas <programgeek@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
Nettyto4.2.6.Finalas a part ofApache Spark 4.1.0preparation.This PR follows the official community migration guide.
Why are the changes needed?
Nettycommunity recommends4.2.Does this PR introduce any user-facing change?
No behavior change.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.