[SPARK-49222][SQL] Clear useless methods in QueryCompilationErrors#47740
[SPARK-49222][SQL] Clear useless methods in QueryCompilationErrors#47740xuzifu666 wants to merge 5 commits into
Conversation
|
@LuciferYang As talk yestday，these methods need to be deleted，PTAL |
| def cannotSaveVariantIntoExternalStorageError(): Throwable = { | ||
| new AnalysisException( | ||
| errorClass = "CANNOT_SAVE_VARIANT", | ||
| messageParameters = Map.empty) |
There was a problem hiding this comment.
Are these two error message templates, CANNOT_SAVE_VARIANT and INDETERMINATE_COLLATION, still needed?
There was a problem hiding this comment.
CANNOT_SAVE_VARIANT can be remove，but INDETERMINATE_COLLATION still in CollationIdentifier which maybe needed. I remove CANNOT_SAVE_VARIANT firstly? @LuciferYang
There was a problem hiding this comment.
CollationIdentifier? INDETERMINATE_COLLATION_ID?
There was a problem hiding this comment.
OK，let's remove INDETERMINATE_COLLATION from error-conditions.json @LuciferYang
|
Let's wait for one more day to see if others have more suggestions. |
|
Can you re-trigger GA? @xuzifu666 |
OK，had rerun failed CI，seems not related to the changed code. @LuciferYang |
MaxGekk
left a comment
There was a problem hiding this comment.
Don't remove the INDETERMINATE_COLLATION error condition so far.
Done |
|
+1, LGTM. Merging to master. |
What changes were proposed in this pull request?
Clear useless methods in QueryCompilationErrors
Why are the changes needed?
Some unused methods in QueryCompilationErrors need to clear
Does this PR introduce any user-facing change?
No
How was this patch tested?
Not need
Was this patch authored or co-authored using generative AI tooling?
No