Revert "[SPARK-46937][SQL] Improve concurrency performance for FunctionRegistry"#46940
Closed
cloud-fan wants to merge 2 commits into
Closed
Revert "[SPARK-46937][SQL] Improve concurrency performance for FunctionRegistry"#46940cloud-fan wants to merge 2 commits into
cloud-fan wants to merge 2 commits into
Conversation
Contributor
Author
dongjoon-hyun
approved these changes
Jun 11, 2024
Member
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for reverting, @cloud-fan .
HyukjinKwon
approved these changes
Jun 11, 2024
Contributor
Author
|
thanks for review, merging to master! |
Member
|
Late LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reverts #44976 as it breaks thread-safety
Why are the changes needed?
Fix thread-safety
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A
Was this patch authored or co-authored using generative AI tooling?
no