[SPARK-47541][SQL][FOLLOWUP] Fix AnsiTypeCoercion to handle ArrayType#46016
Closed
mihailomilosevic2001 wants to merge 4 commits into
Closed
[SPARK-47541][SQL][FOLLOWUP] Fix AnsiTypeCoercion to handle ArrayType#46016mihailomilosevic2001 wants to merge 4 commits into
AnsiTypeCoercion to handle ArrayType#46016mihailomilosevic2001 wants to merge 4 commits into
Conversation
Contributor
Author
|
Fix for #45693 |
Contributor
Author
|
@dongjoon-hyun Could you merge this in to fix the broken tests in master. |
|
|
||
| case aj @ ArrayJoin(arr, d, nr) if !ArrayType(StringType).acceptsType(arr.dataType) && | ||
| case aj @ ArrayJoin(arr, d, nr) | ||
| if !AbstractArrayType(StringTypeAnyCollation).acceptsType(arr.dataType) && |
Member
There was a problem hiding this comment.
nit. We need two more spaces for indentation.
dongjoon-hyun
approved these changes
Apr 11, 2024
Member
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you, @mihailom-db .
I verified ANSI mode manually too.
$ SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly *CollationSuite -- -z complex"
...
[info] All tests passed.
[success] Total time: 134 s (02:14), completed Apr 11, 2024, 3:07:39 PM
AnsiTypeCoercion to handle ArrayType
Member
|
Merged to master for Apache Spark 4.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixing array_join.
Why are the changes needed?
ANSI tests failing.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
CollationSuite in both ANSI and non-ansi mode.
Was this patch authored or co-authored using generative AI tooling?
No.