[SPARK-47804] Add Dataframe cache debug log#45990
Closed
anchovYu wants to merge 4 commits into
Closed
Conversation
| cachedData = cachedData.filterNot(cd => plansToUncache.exists(_ eq cd)) | ||
| } | ||
| plansToUncache.foreach { _.cachedRepresentation.cacheBuilder.clearCache(blocking) } | ||
| CacheManager.logCacheOperation(s"Removed ${plansToUncache.size} Dataframe cache " + |
Member
| .checkValues(StorageLevelMapper.values.map(_.name()).toSet) | ||
| .createWithDefault(StorageLevelMapper.MEMORY_AND_DISK.name()) | ||
|
|
||
| val DATAFRAME_CACHE_LOG_LEVEL = buildConf("spark.sql.dataframeCache.logLevel") |
Member
There was a problem hiding this comment.
Will we need to debug cache table as well? Shall we rename the config as
spark.sql.cache.logLevel
Member
There was a problem hiding this comment.
Also, let's make it an internal conf since it is for developers.
Contributor
Author
There was a problem hiding this comment.
I kept the Dataframe cache naming to differentiate it from the RDD cache.
Member
There was a problem hiding this comment.
RDD is a Spark core concept. Anyway I respect your choice here.
gengliangwang
approved these changes
Apr 15, 2024
Member
|
Thanks, merging to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a debug log for Dataframe cache that uses SQL conf to turn on. It logs necessary information on
Because every query applies cache, this log could be huge and should be only turned on during some debugging process, and should not enabled by default in production.
Example:
Why are the changes needed?
Easier debugging.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run local spark shell.
Was this patch authored or co-authored using generative AI tooling?
No.