[SPARK-47724][PYTHON][TESTS] Add an environment variable for testing remote pure Python library#45868
Closed
HyukjinKwon wants to merge 3 commits into
Closed
[SPARK-47724][PYTHON][TESTS] Add an environment variable for testing remote pure Python library#45868HyukjinKwon wants to merge 3 commits into
HyukjinKwon wants to merge 3 commits into
Conversation
itholic
approved these changes
Apr 4, 2024
Member
Author
|
Merged to master. |
This reverts commit 8e68e6a.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 5, 2024
…ts SPARK_CONNECT_TESTING_REMOTE env ### What changes were proposed in this pull request? This PR is a followup of #45868 that proposes to make testing script to inherits SPARK_CONNECT_TESTING_REMOTE environment variable. ### Why are the changes needed? So the testing script can set `SPARK_CONNECT_TESTING_REMOTE`, and makes the env effective. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested at #45870 ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45886 from HyukjinKwon/SPARK-47724-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add an environment variable called
SPARK_CONNECT_TESTING_REMOTEto setremoteURL.Why are the changes needed?
In order to test pure Python library with a remote server.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.