[SPARK-47358][SQL][COLLATION] Improve repeat expression support to return correct datatype#45615
Closed
miland-db wants to merge 10 commits into
Closed
[SPARK-47358][SQL][COLLATION] Improve repeat expression support to return correct datatype#45615miland-db wants to merge 10 commits into
miland-db wants to merge 10 commits into
Conversation
stefankandic
approved these changes
Mar 20, 2024
Contributor
stefankandic
left a comment
There was a problem hiding this comment.
nit: maybe try formatting your changes (shortcut is option+cmd+l on macos - this will format the entire file, but if you use shift as well you can choose to reformat only uncommitted changes)
HyukjinKwon
reviewed
Mar 21, 2024
c2e8e66 to
fd299f9
Compare
Contributor
Author
|
@MaxGekk @cloud-fan could you please check this and merge it if everything is ok? |
MaxGekk
reviewed
Mar 21, 2024
MaxGekk
reviewed
Mar 25, 2024
cloud-fan
reviewed
Mar 25, 2024
cloud-fan
approved these changes
Mar 25, 2024
Co-authored-by: Wenchen Fan <cloud0fan@gmail.com>
cloud-fan
approved these changes
Mar 25, 2024
Member
|
The GA's failure is not related to the changes, I believe: Run / Run Spark on Kubernetes Integration test +1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Enable collation support for the StringRepeat built-in string function in Spark.
Why are the changes needed?
So we can propagate input string datatype as a result of repeat expression.
Does this PR introduce any user-facing change?
Yes, users will now get different type when using REPEAT on collated strings in Spark SQL queries.
How was this patch tested?
Unit test in
CollationStringExpressionsSuite.scalaWas this patch authored or co-authored using generative AI tooling?
No