[SPARK-42500][SQL] ConstantPropagation support more case#42038
Closed
TongWei1105 wants to merge 1 commit into
Closed
[SPARK-42500][SQL] ConstantPropagation support more case#42038TongWei1105 wants to merge 1 commit into
TongWei1105 wants to merge 1 commit into
Conversation
5712bb5 to
ce86f25
Compare
wangyum
approved these changes
Jul 17, 2023
Member
Contributor
|
I think this PR is very similar to my #40268 so I'm fine with this this change. |
20d286f to
4d1e3a9
Compare
fca478e to
ca42914
Compare
Member
|
@peter-toth This map should usually be small. This change is small and easy to maintain. |
Member
|
Merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR enhances ConstantPropagation to support more cases.
Propagated through other binary comparisons.
Propagated across equality comparisons. This can be further optimized to false.
Why are the changes needed?
Improve query performance. Denodo also has a similar optimization. For example:
Before this PR:
After this PR:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.