[SPARK-37652][SQL]Add test for optimize skewed join through union#34908
Closed
mcdull-zhang wants to merge 1 commit into
Closed
[SPARK-37652][SQL]Add test for optimize skewed join through union#34908mcdull-zhang wants to merge 1 commit into
mcdull-zhang wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
cc @cloud-fan |
Contributor
|
I think #34974 can handle this case. |
Contributor
|
Yea, I think this is already supported. |
Contributor
|
Although we have supported it, I think it's still good to add some test. @mcdull-zhang can you rebase this PR only for the test ? |
1dd7054 to
08c851d
Compare
Contributor
Author
|
@ulysses-you @cloud-fan Please take a look, does the test code make sense? If it doesn't make sense, I'll turn off the pr. |
cloud-fan
approved these changes
Feb 9, 2022
Contributor
|
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#34974, solved most scenarios of data skew in union.
add test for it.
Why are the changes needed?
Added tests for the following scenarios:
scenes 1
scenes 2
scenes 3: not yet supported, SMJ-3 will introduce a new shuffle, so SMJ-1 cannot be optimized
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the added test