Skip to content

[SPARK-35234][CORE] Reserve the format of stage failureMessage #32356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ngone51 wants to merge 3 commits into from
Closed

[SPARK-35234][CORE] Reserve the format of stage failureMessage #32356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
169460b
fix
Ngone51 Apr 27, 2021
78caf0a
revert testing code
Ngone51 Apr 27, 2021
0896255
fix another one
Ngone51 Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1765,10 +1765,9 @@ private[spark] class DAGScheduler(
val abortMessage = if (disallowStageRetryForTest) {
"Fetch failure will not retry stage due to testing config"
} else {
s"""$failedStage (${failedStage.name})
|has failed the maximum allowable number of
|times: $maxConsecutiveStageAttempts.
|Most recent failure reason: $failureMessage""".stripMargin.replaceAll("\n", " ")
s"$failedStage (${failedStage.name}) has failed the maximum allowable number of " +
s"times: $maxConsecutiveStageAttempts. Most recent failure reason:\n" +
failureMessage
}
abortStage(failedStage, abortMessage, None)
} else { // update failedStages and make sure a ResubmitFailedStages event is enqueued
Expand Down Expand Up @@ -1951,11 +1950,8 @@ private[spark] class DAGScheduler(
"Barrier stage will not retry stage due to testing config. Most recent failure " +
s"reason: $message"
} else {
s"""$failedStage (${failedStage.name})
|has failed the maximum allowable number of
|times: $maxConsecutiveStageAttempts.
|Most recent failure reason: $message
""".stripMargin.replaceAll("\n", " ")
s"$failedStage (${failedStage.name}) has failed the maximum allowable number of " +
s"times: $maxConsecutiveStageAttempts. Most recent failure reason: $message"

@Ngone51 Ngone51 Apr 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't append \n for this "Most recent failure reason" because message already contains it:

val message = s"Stage failed because barrier task $task finished unsuccessfully.\n" +
  failure.toErrorString

}
abortStage(failedStage, abortMessage, None)
} else {
Expand Down