[SPARK-21738] Thriftserver doesn't cancel jobs when session is closed#18951
[SPARK-21738] Thriftserver doesn't cancel jobs when session is closed#18951mgaido91 wants to merge 1 commit into
Conversation
|
ok to test |
|
Test build #80705 has finished for PR 18951 at commit
|
|
LGTM based on my limited knowledge on area 😄 . |
|
Thanks! Merging to master. |
|
Hi, @gatorsmile and @mgaido91 . |
|
@dongjoon-hyun I think there is no problem, should I submit a new PR on branch-2.2 too then? |
|
Thank you, @mgaido91 . Please! :) |
|
This issue is not a regression. That is why I did not merge it to branch-2.2 |
|
I see. @gatorsmile . Sorry, @mgaido91 and @gatorsmile . |
|
What happens when a connection is not gracefully closed ? (connection.close() not called, process exits). Does sessions somehow listen to underneath Jetty connection and somehow close themselves ? |
|
Can someone please update on @doruchiulan 's statement? I want to know the same thing. |
|
cc @yaooqinn |
|
FYI, org.apache.thrift.server.TServerEventHandler#deleteContext |
What changes were proposed in this pull request?
When a session is closed the Thriftserver doesn't cancel the jobs which may still be running. This is a huge waste of resources.
This PR address the problem canceling the pending jobs when a session is closed.
How was this patch tested?
The patch was tested manually.