Skip to content

[MINOR][DOC]Replace numTasks with numPartitions in programming guide#18774

Closed
polarker wants to merge 1 commit into
apache:masterfrom
polarker:replace-numtasks-with-numpartitions-in-doc
Closed

[MINOR][DOC]Replace numTasks with numPartitions in programming guide#18774
polarker wants to merge 1 commit into
apache:masterfrom
polarker:replace-numtasks-with-numpartitions-in-doc

Conversation

@polarker
Copy link
Copy Markdown
Contributor

In programming guide, numTasks is used in several places as arguments of Transformations. However, in code, numPartitions is used. In this fix, I replace numTasks with numPartitions in programming guide for consistency.

@remisharoon
Copy link
Copy Markdown

@polarke , can you please provide the details of how you tested this?
please provide screenshots of the locally tested doc site

@remisharoon
Copy link
Copy Markdown

remisharoon commented Jul 30, 2017

@polarke :
please refer to this Pull Request 18770 for best practices

Copy link
Copy Markdown
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remisharoon in this case I don't think a screenshot is needed. The nature of the change is clear from the diff. I think the change is OK.

@SparkQA
Copy link
Copy Markdown

SparkQA commented Jul 30, 2017

Test build #3862 has finished for PR 18774 at commit ec11300.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked and it looks okay to me too.

@srowen
Copy link
Copy Markdown
Member

srowen commented Jul 30, 2017

Merged to master

@asfgit asfgit closed this in 6830e90 Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants