[GH-3161] Fix RT90 transform accuracy - #3167
Closed
jiayuasu wants to merge 1 commit into
Closed
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes ST_Transform is off by > 180 meters since Sedona 1.9 #3161.What changes were proposed in this PR?
Upgrade proj4sedona from 0.1.2 to 0.1.3 and add a regression test for transforming RT90 (
EPSG:3021) to SWEREF99 TM (EPSG:3006).Sedona 1.9 switched CRS transformation to proj4sedona, but version 0.1.2 lacked the generated RT90 datum definition. The transform therefore omitted the required datum shift and produced an error exceeding 180 metres. Version 0.1.3 includes the complete upstream datum registry and restores the RT90 Helmert transformation.
How was this patch tested?
mvn spotless:apply -Dscala=2.12 -Dspark=3.4 -Bmvn -Dspark=3.4 -Dscala=2.12 -pl spark/common -am -DskipTests install -Bmvn -Dspark=3.4 -Dscala=2.12 -pl spark/common -Dtest=__NoJavaTests__ -Dsurefire.failIfNoSpecifiedTests=false -Dsuites=org.apache.sedona.sql.CRSTransformProj4Test test -BCRSTransformProj4Test: 37/37 tests passed, including the ST_Transform is off by > 180 meters since Sedona 1.9 #3161 regression.2df4a9477ba4609d0b4dc34196b9fd1e44bc85b609e9ac6a726b559aad85d487).Did this PR include necessary documentation updates?