[GH-2396] Making splitting polygon by line robust by removing the computation of line-polygon intersection#2598
Merged
jiayuasu merged 2 commits intoapache:masterfrom Jan 22, 2026
Conversation
Member
Author
|
The Python test failures is likely caused by the release of Pandas 3.0. I'll fix it in another PR. |
jiayuasu
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. ClosesGeometrySplitter.splitreturns empty geometry #2396What changes were proposed in this PR?
This patch fixes splitting a polygon using linestring by porting the corresponding logic from PostGIS. Relevant PostGIS code: https://github.com/postgis/postgis/blob/3.6.1/liblwgeom/lwgeom_geos_split.c#L349-L491
How was this patch tested?
Added the case mentioned in the issue as a unit test and pass it.
Did this PR include necessary documentation updates?