Skip to content

Updated: the header to show the tagline only when its available#99

Merged
mbien merged 2 commits intoapache:masterfrom
ymaheshwari1:update-theme-fauxcoly
Jul 23, 2021
Merged

Updated: the header to show the tagline only when its available#99
mbien merged 2 commits intoapache:masterfrom
ymaheshwari1:update-theme-fauxcoly

Conversation

@ymaheshwari1
Copy link
Copy Markdown
Contributor

Added an if condition to check whether the weblog has a tagline defined or not and if there is a tagline present then only displaying the tagline.

Before:
Tagline is always displayed.
image

After:
Tagline is only displayed when its defined
image

If tagline is not present then nothing is displayed.
image

@mbien
Copy link
Copy Markdown
Member

mbien commented Jul 18, 2021

Hi Yash, have you checked if this can also happen with the other themes?

@ymaheshwari1
Copy link
Copy Markdown
Contributor Author

Hi @mbien I am checking other themes for the same.

@mbien
Copy link
Copy Markdown
Member

mbien commented Jul 23, 2021

lgtm, integrating

@mbien mbien merged commit 94ebf3b into apache:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants