Replaced deprecated rome-fetcher with java 11 HttpClient#92
Merged
mbien merged 1 commit intoapache:masterfrom Jul 4, 2021
Merged
Replaced deprecated rome-fetcher with java 11 HttpClient#92mbien merged 1 commit intoapache:masterfrom
mbien merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
Very nice! don't see any problems here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rome-fetcher can be relatively easy replaced with Java 11 HttpClient while still using the non-deprecated parts of Apache ROME, the only piece missing is the on-disk feed cache.
Interestingly, it appears that the cache was only used as workaround to timestamp feeds which did not have update dates in them. So removing the cache might alter the logic slightly for feed entries without update date since they are always seen as not modified now.
It would be great if someone with Roller Planet experience could check if the aggregator is still working as expected. Tests are green.