Skip to content

Parse referrer URL instead of using string value directly.#90

Merged
snoopdave merged 7 commits intoapache:masterfrom
snoopdave:parse-referrer
Jul 4, 2021
Merged

Parse referrer URL instead of using string value directly.#90
snoopdave merged 7 commits intoapache:masterfrom
snoopdave:parse-referrer

Conversation

@snoopdave
Copy link
Copy Markdown
Contributor

@snoopdave snoopdave commented May 31, 2021

This PR changes the logic for processing referers so that the referer URL is validated before storage.

@mbien
Copy link
Copy Markdown
Member

mbien commented May 31, 2021

LGTM, small remark for your consideration:

org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flow. Lib is already in the dependencies.

example snippet in doc

@snoopdave
Copy link
Copy Markdown
Contributor Author

LGTM, small remark for your consideration:

org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flow. Lib is already in the dependencies.

example snippet in doc

Thanks for the review. I switched over to URLValidator as you suggested.

@mbien
Copy link
Copy Markdown
Member

mbien commented Jun 6, 2021

@snoopdave excellent. LGTM. (the fixed test looks good too, I was wondering if it was only failing on my machine)

@mbien
Copy link
Copy Markdown
Member

mbien commented Jun 20, 2021

4c55a62 regexp eval replacement logic looks good to me

@snoopdave snoopdave merged commit 58e61b0 into apache:master Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants