Parse referrer URL instead of using string value directly.#90
Merged
snoopdave merged 7 commits intoapache:masterfrom Jul 4, 2021
Merged
Parse referrer URL instead of using string value directly.#90snoopdave merged 7 commits intoapache:masterfrom
snoopdave merged 7 commits intoapache:masterfrom
Conversation
Member
|
LGTM, small remark for your consideration: org.apache.commons.validator.routines.UrlValidator might be better since it does not rely on the exception in the program flow. Lib is already in the dependencies. example snippet in doc |
Contributor
Author
Thanks for the review. I switched over to |
Member
|
@snoopdave excellent. LGTM. (the fixed test looks good too, I was wondering if it was only failing on my machine) |
Member
|
4c55a62 regexp eval replacement logic looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the logic for processing referers so that the referer URL is validated before storage.