Merged
Conversation
Member
|
if i remember correctly JSTL libs are supposed to be placed in the classpath of the server/container, not the application. However, these days this should not make any difference anymore since there is usually only one app per server instance - so not much can go wrong. Keeping it in the roller war for convenience reasons is probably fine - i don't think anyone complained so far :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes provided scope for JSTL becuase JSTL is not provided by Tomcat. I erroneously added provided scope a couple months ago when I was trying to get the Maven Jetty stuff working.