Merged
Conversation
Caused a NoClassDefFoundError in struts when it tried to inspect a log4j2 class via reflection which had optional dependencies.
…leak anymore. + removed hard dependency to log4j1 + fix/opt: getProperty() called config.getProperty() twice
new setup: - commons-logging impl is replaced by jcl-over-slf4j impl, interfaces remain - java.util.logging is redirected to slf4j (used by WebJars dep, possibly others) - eclipselink is configured to use its own slf4j logger - log4j-slf4j-impl (which is log4j2) is used as actual logging impl changes: - loggers can no longer be configured using roller.properties or roller-custom.properties. - configuration is now in log4j2.xml. - a custom config file can be set using the standard log4j.configurationFile system property. (can be for example in roller-custom.properties or set as JVM -D property)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@snoopdave this PR contains changes which move roller to log4j2
ce48772 refactors WebLoggerConfig to prepare for the actual move
8239a8d is the main commit: