fixBug PropertyNotFoundException

[DKARAGODIN]

During deploy on clean Wildfly 19 installation there were the foollowing exception:
org.hibernate.PropertyNotFoundException: Could not locate setter method for property [org.apache.roller.weblogger.pojos.WeblogEntryComment#emptyString]
Adding missing element for emptyString property in orm descriptor fixes the problem.

[mbien]

@snoopdave do you remember why emptyString is used here instead of listValue=""? Maybe we can remove the method (org.apache.roller.weblogger.pojos.WeblogEntryComment#getEmptyString) again.

roller/app/src/main/webapp/WEB-INF/jsps/editor/Comments.jsp

Lines 213 to 214 in 19f7f12

	<s:checkboxlist name="bean.approvedComments" cssClass="comment-select"
	list="#comment" listKey="id" listValue="emptyString" />

[DKARAGODIN]

No, unfortunately, I don't know. I only build this project once and tried it for couple hours.

When I discovered the issue and created this pull request I remember that I browsed commit history and conclude that somebody simply forgot to add the line to orm descriptor. I did not analyze weather it could be removed altogether.

[mbien]

@DKARAGODIN i would like to remove it if possible, i am only waiting for @snoopdave maybe he remembers why he added the getEmptyString method. It does seem to work for me when I set listValue="" without a method call.

I just want to make sure that we don't remove a workaround which was probably there for a reason.

[snoopdave]

I do not remember why I had to add that weird and annoying getEmptyString() method and if things work now without it then we should remove.

[mbien]

@snoopdave thanks for the info. I ran a quick test and the checkboxes seem work fine without the method call.

@DKARAGODIN since you contributed the original fix, would you like to change it so that:

roller/app/src/main/webapp/WEB-INF/jsps/editor/Comments.jsp

Lines 213 to 223 in 19f7f12

	<s:checkboxlist name="bean.approvedComments" cssClass="comment-select"
	list="#comment" listKey="id" listValue="emptyString" />
	</td>
	</s:if>
	<td>
	<s:checkboxlist name="bean.spamComments" cssClass="comment-select"
	list="#comment" listKey="id" listValue="emptyString" />
	</td>
	<td>
	<s:checkboxlist name="bean.deleteComments" cssClass="comment-select"
	list="#comment" listKey="id" listValue="emptyString" />

all 3 checkboxes use listValue=""

and remove the following method

roller/app/src/main/java/org/apache/roller/weblogger/pojos/WeblogEntryComment.java

Lines 295 to 298 in 19f7f12

	public String getEmptyString() {
	return "";
	}

?

feel free to force push a new commit to this PR. If you don't want to or don't have time its completely fine.

[DKARAGODIN]

I think I can't do it. I deleted forked repository from which i suggested this PR.
And I also could not find this commit in my local repository.

[mbien]

no worries. I can close this PR no problem. I am going to create a new one this weekend for this issue, unless someone else already created one. If you want to give it another try feel free to do so.

[snoopdave]

LGTM