Skip to content

Minor fixes in Velocity Templates and dependency updates#112

Merged
snoopdave merged 4 commits intoapache:masterfrom
mbien:templates
Jan 1, 2022
Merged

Minor fixes in Velocity Templates and dependency updates#112
snoopdave merged 4 commits intoapache:masterfrom
mbien:templates

Conversation

@mbien
Copy link
Copy Markdown
Member

@mbien mbien commented Dec 25, 2021 •
edited
Loading

  • Apache Rome had a release (yey)
  • another week, another CVE https://logging.apache.org/log4j/2.x/
  • templates should use $foreach.index in loops, old $velocityCount isn't working anymore
  • another stream was left open
  • Registered some maven actions for NetBeans

mbien added 2 commits December 25, 2021 08:14
@mbien
updated velocity templates.
329f1aa 
- use $foreach.index instead of old $velocityCount in loops.
- don't use deprecated methods
@mbien
close stream.
e74ba32
@mbien mbien requested a review from snoopdave December 25, 2021 09:15
snoopdave
snoopdave approved these changes Dec 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Velocity changes LGTM. Do the Netbeans changes allow you to debug tests in the IDE?

@mbien
Copy link
Copy Markdown
Member Author

mbien commented Dec 27, 2021

Velocity changes LGTM. Do the Netbeans changes allow you to debug tests in the IDE?

Its mostly for registering non-standard maven goals. like jetty:run, or the selenium tests which have to specify a path to the "geckodriver". Pressing the run/debug button on Roller webapp or the Selenium tests will do the right thing. Debugging junit did actually work before already since netbeans knows how to use that plugin.

There is also a "display-dependency-updates" action registered for the root project to quickly check if something can be updated.

I am not feeling strongly about it. If you don't want it in the repository I can leave it out and put nbactions.xml on gitignore.

@snoopdave
Copy link
Copy Markdown
Contributor

snoopdave commented Dec 27, 2021

Cool. I'm all for it if it makes things easier for folks using Netbeans.

@snoopdave snoopdave merged commit 287bc9f into apache:master Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoopdave snoopdave snoopdave approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbien @snoopdave